Return-Path: X-Original-To: apmail-flex-commits-archive@www.apache.org Delivered-To: apmail-flex-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C65CEFEE5 for ; Fri, 19 Apr 2013 15:37:31 +0000 (UTC) Received: (qmail 98168 invoked by uid 500); 19 Apr 2013 15:36:24 -0000 Delivered-To: apmail-flex-commits-archive@flex.apache.org Received: (qmail 97374 invoked by uid 500); 19 Apr 2013 15:36:18 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 94113 invoked by uid 99); 19 Apr 2013 15:33:54 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Apr 2013 15:33:54 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 7C0D0324BAE; Fri, 19 Apr 2013 15:33:54 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: erikdebruin@apache.org To: commits@flex.apache.org Date: Fri, 19 Apr 2013 15:34:00 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [07/19] git commit: [flex-falcon] - [FalconJX] resolved TODO [FalconJX] resolved TODO The new 'require' parser in FlexJS will include all namespaces that are actually used in a class. Signed-off-by: Erik de Bruin Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/ce60cb7d Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/ce60cb7d Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/ce60cb7d Branch: refs/heads/develop Commit: ce60cb7dcf8a997c5dbe2dff266c65d0f19504a1 Parents: 4939e44 Author: Erik de Bruin Authored: Fri Apr 19 16:35:42 2013 +0200 Committer: Erik de Bruin Committed: Fri Apr 19 16:35:42 2013 +0200 ---------------------------------------------------------------------- .../codegen/js/goog/TestGoogExpressions.java | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/ce60cb7d/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java ---------------------------------------------------------------------- diff --git a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java index 47f419f..8938da9 100644 --- a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java +++ b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java @@ -174,7 +174,6 @@ public class TestGoogExpressions extends TestExpressions @Test public void testVisitBinaryOperator_NamespaceAccess_1() { - // TODO (erikdebruin) we need a 'goog.require("a")' in the header INamespaceAccessExpressionNode node = (INamespaceAccessExpressionNode) getExpressionNode( "a::b", INamespaceAccessExpressionNode.class); asBlockWalker.visitNamespaceAccessExpression(node); @@ -185,7 +184,6 @@ public class TestGoogExpressions extends TestExpressions @Test public void testVisitBinaryOperator_NamespaceAccess_2() { - // TODO (erikdebruin) we need a 'goog.require("a.b")' in the header INamespaceAccessExpressionNode node = (INamespaceAccessExpressionNode) getExpressionNode( "a::b::c", INamespaceAccessExpressionNode.class); asBlockWalker.visitNamespaceAccessExpression(node);