flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [07/19] git commit: [flex-falcon] - [FalconJX] resolved TODO
Date Fri, 19 Apr 2013 15:34:00 GMT
[FalconJX] resolved TODO

The new 'require' parser in FlexJS will include all namespaces that are actually used in a
class.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/ce60cb7d
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/ce60cb7d
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/ce60cb7d

Branch: refs/heads/develop
Commit: ce60cb7dcf8a997c5dbe2dff266c65d0f19504a1
Parents: 4939e44
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Fri Apr 19 16:35:42 2013 +0200
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Fri Apr 19 16:35:42 2013 +0200

----------------------------------------------------------------------
 .../codegen/js/goog/TestGoogExpressions.java       |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/ce60cb7d/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java
----------------------------------------------------------------------
diff --git a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java
index 47f419f..8938da9 100644
--- a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java
+++ b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/goog/TestGoogExpressions.java
@@ -174,7 +174,6 @@ public class TestGoogExpressions extends TestExpressions
     @Test
     public void testVisitBinaryOperator_NamespaceAccess_1()
     {
-        // TODO (erikdebruin) we need a 'goog.require("a")' in the header
         INamespaceAccessExpressionNode node = (INamespaceAccessExpressionNode) getExpressionNode(
                 "a::b", INamespaceAccessExpressionNode.class);
         asBlockWalker.visitNamespaceAccessExpression(node);
@@ -185,7 +184,6 @@ public class TestGoogExpressions extends TestExpressions
     @Test
     public void testVisitBinaryOperator_NamespaceAccess_2()
     {
-        // TODO (erikdebruin) we need a 'goog.require("a.b")' in the header
         INamespaceAccessExpressionNode node = (INamespaceAccessExpressionNode) getExpressionNode(
                 "a::b::c", INamespaceAccessExpressionNode.class);
         asBlockWalker.visitNamespaceAccessExpression(node);


Mime
View raw message