Return-Path: X-Original-To: apmail-flex-commits-archive@www.apache.org Delivered-To: apmail-flex-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32280DD09 for ; Tue, 8 Jan 2013 12:57:04 +0000 (UTC) Received: (qmail 91071 invoked by uid 500); 8 Jan 2013 12:57:04 -0000 Delivered-To: apmail-flex-commits-archive@flex.apache.org Received: (qmail 91032 invoked by uid 500); 8 Jan 2013 12:57:04 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 91025 invoked by uid 99); 8 Jan 2013 12:57:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2013 12:57:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2013 12:57:02 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 72EC82388A4A; Tue, 8 Jan 2013 12:56:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1430264 - in /flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal: as/codegen/TestGlobalConstants.java js/codegen/goog/TestGoogFieldMembers.java js/codegen/goog/TestGoogGlobalConstants.java Date: Tue, 08 Jan 2013 12:56:43 -0000 To: commits@flex.apache.org From: erikdebruin@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130108125643.72EC82388A4A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: erikdebruin Date: Tue Jan 8 12:56:42 2013 New Revision: 1430264 URL: http://svn.apache.org/viewvc?rev=1430264&view=rev Log: - tests now pass for '-Infinity' - added a test for the assignment of a negative number to a var (wrote it while looking for cause of the -Infinity bug) Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java?rev=1430264&r1=1430263&r2=1430264&view=diff ============================================================================== --- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java (original) +++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java Tue Jan 8 12:56:42 2013 @@ -21,7 +21,6 @@ package org.apache.flex.compiler.interna import org.apache.flex.compiler.tree.as.IFileNode; import org.apache.flex.compiler.tree.as.IVariableNode; -import org.junit.Ignore; import org.junit.Test; /** @@ -37,11 +36,9 @@ public class TestGlobalConstants extends assertOut("var a:Number = Infinity"); } - @Ignore @Test public void testNegativeInfinity() { - // TODO (erikdebruin) Mike, why is this failing? IVariableNode node = getField("var a:Number = -Infinity;"); visitor.visitVariable(node); assertOut("var a:Number = -Infinity"); Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java?rev=1430264&r1=1430263&r2=1430264&view=diff ============================================================================== --- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java (original) +++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java Tue Jan 8 12:56:42 2013 @@ -69,6 +69,14 @@ public class TestGoogFieldMembers extend assertOut("/**\n * @type {number}\n */\nA.prototype.foo = 420"); } + @Test + public void testField_withTypeValue_Negative() + { + IVariableNode node = getField("var foo:int = -420;"); + visitor.visitVariable(node); + assertOut("/**\n * @type {number}\n */\nA.prototype.foo = -420"); + } + @Override @Test public void testField_withNamespaceTypeValue() Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java?rev=1430264&r1=1430263&r2=1430264&view=diff ============================================================================== --- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java (original) +++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java Tue Jan 8 12:56:42 2013 @@ -24,7 +24,6 @@ import org.apache.flex.compiler.internal import org.apache.flex.compiler.internal.js.codegen.JSSharedData; import org.apache.flex.compiler.internal.js.driver.goog.GoogBackend; import org.apache.flex.compiler.tree.as.IVariableNode; -import org.junit.Ignore; import org.junit.Test; /** @@ -43,7 +42,6 @@ public class TestGoogGlobalConstants ext assertOut("A.prototype.a = Infinity"); } - @Ignore @Override @Test public void testNegativeInfinity()