flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mschma...@apache.org
Subject svn commit: r1437353 - in /flex/falcon/trunk: compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/ compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ compiler.jx/sr...
Date Wed, 23 Jan 2013 11:37:44 GMT
Author: mschmalle
Date: Wed Jan 23 11:37:43 2013
New Revision: 1437353

URL: http://svn.apache.org/viewvc?rev=1437353&view=rev
Log:
Flex:FalconJx
- a couple todos erased and visit compilation unit taken out of switch

Modified:
    flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
    flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
    flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ASNodeSwitch.java
    flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/visitor/IASBlockVisitor.java

Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java?rev=1437353&r1=1437352&r2=1437353&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
(original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
Wed Jan 23 11:37:43 2013
@@ -28,8 +28,6 @@ import org.junit.Test;
  */
 public class TestComments extends TestWalkerBase
 {
-	// TODO (erikdebruin/mschmalle) why aren't comments preserved?
-    
 	@Ignore
 	@Test
     public void testComment_SingleLine()

Modified: flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java?rev=1437353&r1=1437352&r2=1437353&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
(original)
+++ flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
Wed Jan 23 11:37:43 2013
@@ -749,7 +749,6 @@ public class ASEmitter implements IASEmi
 
     protected void emitFunctionScope(IScopedNode node)
     {
-        // TODO (mschmalle) FunctionObjectNode; does this need specific treatment?
         emitMethodScope(node);
     }
 

Modified: flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ASNodeSwitch.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ASNodeSwitch.java?rev=1437353&r1=1437352&r2=1437353&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ASNodeSwitch.java
(original)
+++ flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/visitor/ASNodeSwitch.java
Wed Jan 23 11:37:43 2013
@@ -63,7 +63,6 @@ import org.apache.flex.compiler.tree.as.
 import org.apache.flex.compiler.tree.as.IWithNode;
 import org.apache.flex.compiler.tree.metadata.IMetaTagNode;
 import org.apache.flex.compiler.tree.metadata.IMetaTagsNode;
-import org.apache.flex.compiler.units.ICompilationUnit;
 import org.apache.flex.compiler.visitor.IASBlockVisitor;
 import org.apache.flex.compiler.visitor.IASNodeStrategy;
 
@@ -95,12 +94,7 @@ public class ASNodeSwitch implements IAS
     @Override
     public void handle(IASNode node)
     {
-        if (node instanceof ICompilationUnit)
-        {
-            visitor.visitCompilationUnit((ICompilationUnit) node);
-            return;
-        }
-
+        // TODO (mschmalle) Still working on the switch, its complication in the expressions
         switch (node.getNodeID())
         {
         case FileID:

Modified: flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/visitor/IASBlockVisitor.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/visitor/IASBlockVisitor.java?rev=1437353&r1=1437352&r2=1437353&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/visitor/IASBlockVisitor.java
(original)
+++ flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/visitor/IASBlockVisitor.java
Wed Jan 23 11:37:43 2013
@@ -20,7 +20,6 @@
 package org.apache.flex.compiler.visitor;
 
 import org.apache.flex.compiler.internal.as.codegen.ASBlockWalker;
-import org.apache.flex.compiler.internal.as.visitor.ASNodeSwitch;
 import org.apache.flex.compiler.internal.tree.as.LabeledStatementNode;
 import org.apache.flex.compiler.internal.tree.as.NamespaceAccessExpressionNode;
 import org.apache.flex.compiler.tree.as.IASNode;
@@ -72,12 +71,6 @@ import org.apache.flex.compiler.units.IC
  * delegate within it's {@link IASNodeStrategy#handle(IASNode)} method to this
  * API's visitor method.
  * <p>
- * Currently the {@link ASNodeSwitch} class is a monolithic if else statement
- * using instanceof to switch on the correct {@link IASNode} interface type.
- * This is where more experienced developers in Java might know a way that is
- * more efficient but, currently it works well, performance on the instanceof
- * will have to be determined.
- * <p>
  * <strong>Note</strong> This API is not complete.
  * 
  * @author Michael Schmalle



Mime
View raw message