Mailing-List: contact dev-help@fleece.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fleece.incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of hendrikdev22@gmail.com
 designates 209.85.215.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CACLE=7N2GUNFJxr5zH41ipZsy6-yHmgNpqFWncb6sC9KjB39iA@mail.gmail.com>
References: 
 <CAPm=oFBfxPyF8rbCfJU4HsMyd+45hGz=RawmL1vOkdi3DqzRkg@mail.gmail.com>
	<CACLE=7NypjMp31g4aztPU_M_9DtGMoc+55oDrjr4QX0iTchjRw@mail.gmail.com>
	<CAPm=oFDZqPoBXn3QQszLsp7p3d6eydxc4OozVoUmBKPFKfTS7A@mail.gmail.com>
	<CACLE=7N2GUNFJxr5zH41ipZsy6-yHmgNpqFWncb6sC9KjB39iA@mail.gmail.com>
Date: Sat, 5 Jul 2014 10:11:22 +0200
Message-ID: 
 <CAPm=oFCLh18nP06JhagrE7+9n4dt3QUhav0QKvcPrNSa=Za1ZQ@mail.gmail.com>
Subject: Re: Some suggestions for Strings.java and JsonLongImpl.java
From: Hendrik Dev <hendrikdev22@gmail.com>
To: "dev@fleece.incubator.apache.org" <dev@fleece.incubator.apache.org>
Content-Type: text/plain; charset=UTF-8

The Strings.java JMH based benchmark i did can be found here
https://github.com/salyh/fleece_tmp/tree/benchmark-streamparser/fleece-core

avg_benchmark_jmh_result_f2_t16_w3_i5.txt for example shows

Benchmark Mode Samples Score Score error Units
o.a.f.c.j.b.BenchmarkStringsCompact.normalWithUnicode
avgt        10   117411,047     6748,646    us/op
o.a.f.c.j.b.BenchmarkStringsCompact.normalWithoutUnicode
avgt        10   118481,121    10540,816    us/op
o.a.f.c.j.b.BenchmarkStringsCompact.optimizedWithUnicode
avgt        10   102078,601     7623,861    us/op
o.a.f.c.j.b.BenchmarkStringsCompact.optimizedWithoutUnicode
avgt        10   125038,896     8359,245    us/op

There is no real improvement if i read the figures correctly.

@romain: BTW what do exactly mean with "slow hashcode computation"?
hashcode of what?


Implementations:
https://github.com/salyh/fleece_tmp/blob/benchmark-streamparser/fleece-core/src/main/java/org/apache/fleece/core/Strings_Optimized.java
https://github.com/salyh/fleece_tmp/blob/benchmark-streamparser/fleece-core/src/main/java/org/apache/fleece/core/Strings.java

Thanks
Hendrik

On Sat, Jun 28, 2014 at 11:58 PM, Romain Manni-Bucau
<rmannibucau@gmail.com> wrote:
> Ok,
>
> thanks a lot for the jira + patch (I know it looks too much for 1 word
> but makes obvious you contributed the patch ;)).
>
> Waiting to read the result of your tests ;)
>
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
> 2014-06-28 23:36 GMT+02:00 Hendrik Dev <hendrikdev22@gmail.com>:
>> jira issue opened
>>
>> regarding the figures: i have some measurements on my own and the code
>> shows a slight speedup, but i will look into
>> https://github.com/RichardHightower/json-parsers-benchmark
>>
>> On Sat, Jun 28, 2014 at 11:16 PM, Romain Manni-Bucau
>> <rmannibucau@gmail.com> wrote:
>>> second fix is ok (please open a jira and attach a patch)
>>>
>>> the first one need figures (I used
>>> https://github.com/RichardHightower/json-parsers-benchmark ), last
>>> time I tried such a thing computing hashcode was too slow.
>>>
>>>
>>> Romain Manni-Bucau
>>> Twitter: @rmannibucau
>>> Blog: http://rmannibucau.wordpress.com/
>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>> Github: https://github.com/rmannibucau
>>>
>>>
>>> 2014-06-28 23:01 GMT+02:00 Hendrik Dev <hendrikdev22@gmail.com>:
>>>> only constants in escape() method, unicode cache, clean up of possibly
>>>> unnecessary code
>>>> https://github.com/salyh/fleece_tmp/commit/a8d852bc3beeddc9607af1005a2cfdde2f252230
>>>>
>>>> long is integral
>>>> https://github.com/salyh/fleece_tmp/commit/03dc2df406d171ded8db5199d4618786d29e5298
>>>>
>>>> Thanks
>>>> Hendrik


-- 
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC