fleece-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEECE-1) JsonArrayBuilderImpl does not throw npe/nfe as described in api
Date Fri, 27 Jun 2014 12:39:24 GMT

    [ https://issues.apache.org/jira/browse/FLEECE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045905#comment-14045905
] 

Romain Manni-Bucau commented on FLEECE-1:
-----------------------------------------

Hi

Seems there is a typo in :

{code}
     @Override
     public JsonArrayBuilder add(final JsonObjectBuilder builder) {
+    	if(builder == null) new NullPointerException("builder must not be null");
         array.addInternal(builder.build());
         return this;
     }
 
     @Override
     public JsonArrayBuilder add(final JsonArrayBuilder builder) {
+    	if(builder == null) new NullPointerException("builder must not be null");
         array.addInternal(builder.build());
         return this;
     }
{code}

(NPE are not thrown)

Do you care fixing it before we apply the patch?

>  JsonArrayBuilderImpl does not throw npe/nfe as described in api
> ----------------------------------------------------------------
>
>                 Key: FLEECE-1
>                 URL: https://issues.apache.org/jira/browse/FLEECE-1
>             Project: Fleece
>          Issue Type: Bug
>            Reporter: Hendrik Saly
>            Priority: Minor
>         Attachments: 0001-jsonarraybuilder-now-throws-npe-nfe-as-described-in-.patch
>
>
>  JsonArrayBuilderImpl does not throw npe/nfe as described in api



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message