Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 12E74200D39 for ; Sat, 11 Nov 2017 08:00:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 11690160C03; Sat, 11 Nov 2017 07:00:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5806A160BF1 for ; Sat, 11 Nov 2017 08:00:09 +0100 (CET) Received: (qmail 53763 invoked by uid 500); 11 Nov 2017 07:00:08 -0000 Mailing-List: contact issues-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list issues@fineract.apache.org Received: (qmail 53754 invoked by uid 99); 11 Nov 2017 07:00:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2017 07:00:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 61F82DA2D1 for ; Sat, 11 Nov 2017 07:00:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Pr4p2I2kyr6L for ; Sat, 11 Nov 2017 07:00:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C3A75FE5F for ; Sat, 11 Nov 2017 07:00:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 871ECE045B for ; Sat, 11 Nov 2017 07:00:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4C728240D2 for ; Sat, 11 Nov 2017 07:00:05 +0000 (UTC) Date: Sat, 11 Nov 2017 07:00:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@fineract.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FINERACT-554) The ledger entry for allocate cash transaction to cashier has USD as hard coded curreny MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 11 Nov 2017 07:00:10 -0000 [ https://issues.apache.org/jira/browse/FINERACT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248373#comment-16248373 ] ASF GitHub Bot commented on FINERACT-554: ----------------------------------------- GitHub user nikpawar89 opened a pull request: https://github.com/apache/fineract/pull/425 FINERACT-554 When cash is allocated to cashier, its corresponding GL entry has currency as USD, no matter what currency is configured for the organisation. On further debugging it was found that the USD was hard coded in the code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikpawar89/incubator-fineract FINERACT-554 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/fineract/pull/425.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #425 ---- commit f1e6716f76bd30b007504373f34ba054e9d0bb5c Author: nikpawar89 Date: 2017-11-11T06:57:51Z FINERACT-554 ---- > The ledger entry for allocate cash transaction to cashier has USD as hard coded curreny > --------------------------------------------------------------------------------------- > > Key: FINERACT-554 > URL: https://issues.apache.org/jira/browse/FINERACT-554 > Project: Apache Fineract > Issue Type: Bug > Components: Organization > Reporter: Nikhil Pawar > Assignee: Markus Geiss > > When cash is allocated to cashier, its corresponding GL entry has currency as USD, no matter what currency is configured for the organisation. > On further debugging it was found that the USD was hard coded in the code. > Refer line 443 and 452 of TellerWritePlatformServiceJpaImpl.java: > https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerWritePlatformServiceJpaImpl.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)