Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C4CF6200D35 for ; Tue, 7 Nov 2017 13:44:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C33A5160BED; Tue, 7 Nov 2017 12:44:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1605E1609C8 for ; Tue, 7 Nov 2017 13:44:05 +0100 (CET) Received: (qmail 48667 invoked by uid 500); 7 Nov 2017 12:44:05 -0000 Mailing-List: contact issues-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list issues@fineract.apache.org Received: (qmail 48658 invoked by uid 99); 7 Nov 2017 12:44:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2017 12:44:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7D8AD18E5C8 for ; Tue, 7 Nov 2017 12:44:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LLB02R32HV2A for ; Tue, 7 Nov 2017 12:44:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 364B561DCF for ; Tue, 7 Nov 2017 12:44:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6B7D1E0E7A for ; Tue, 7 Nov 2017 12:44:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 91AA4241A3 for ; Tue, 7 Nov 2017 12:44:00 +0000 (UTC) Date: Tue, 7 Nov 2017 12:44:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@fineract.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FINERACT-491) Savings annual compound doesn't respect Fiscal month (in April) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 07 Nov 2017 12:44:06 -0000 [ https://issues.apache.org/jira/browse/FINERACT-491?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 241944#comment-16241944 ]=20 ASF GitHub Bot commented on FINERACT-491: ----------------------------------------- GitHub user nazeer1100126 opened a pull request: https://github.com/apache/fineract/pull/423 FINERACT-491 :fiscal month compounding =20 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nazeer1100126/incubator-fineract fiscal_m= onth Alternatively you can review and apply these changes as the patch at: https://github.com/apache/fineract/pull/423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #423 =20 ---- commit 630c942fa386944c8d9d886ade41edb934971bf5 Author: nazeer shaik Date: 2017-11-07T12:42:07Z FINERACT-491 :fiscal month compounding ---- > Savings annual compound doesn't respect Fiscal month (in April) > --------------------------------------------------------------- > > Key: FINERACT-491 > URL: https://issues.apache.org/jira/browse/FINERACT-491 > Project: Apache Fineract > Issue Type: Bug > Components: Savings > Affects Versions: 1.0.0 > Environment: Windows > Reporter: thynn win > Assignee: Shaik Nazeer Hussain > Priority: Critical > Labels: p1 > Attachments: sample.jpg > > > We are observing that Mifos doesn=E2=80=99t respect the fiscal month in c= alculating interest for savings. > =20 > For instance: we configured the fiscal year to start in April. The saving= product is annual interest with 15% and 365 days. Compounding is set to an= nual with daily balance. > If we make a saving deposit of $1000 on June 23, 2016 and trying to post = on April 1 2017, our expectation is that the interest will be $115.89 (1000= *282*0.0004109589). =20 > There are a total of 282 days with daily interest rate of 0.0004109589 (1= /365*0.15).=20 > =20 > In Mifos, we are getting $118.81 instead. What we learned is that there i= s a compounding happening on Dec 31, 2016 even though it=E2=80=99s not a fi= scal year end.=20 > From June 23 to Dec 31, there are 192 days and it=E2=80=99s getting a new= available balance on Jan 1. It=E2=80=99s compounding from Jan 1, 2017. > https://demo.openmf.org/#/viewsavingaccount/887 (see screenshot) > =20 > =20 > When digging through the code, even though Fiscal month is passed around = in the interest calculation, it wasn=E2=80=99t used when determining compou= nding periods.=20 > =20 > File: PostingPeriod.java > Method: determineInterestPeriodEndDateFrom > case ANNUAL: > periodEndDate =3D periodStartDate.monthOfYear().withMaxim= umValue(); //This is causing to default the compound period to Dec as perio= d start year is 2016. > periodEndDate =3D periodEndDate.dayOfMonth().withMaximumV= alue(); > We are still trying to go through the logic and we=E2=80=99d greatly app= reciate your help. > This will become an issue in Jan 2018 as it's compounding when it's not s= upposed to be. > =20 > Thank you. -- This message was sent by Atlassian JIRA (v6.4.14#64029)