fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] fineract pull request #403: Extend-mifos-data-import-tool chartOfAccounts po...
Date Thu, 17 Aug 2017 06:26:40 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/403#discussion_r133631616
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java
---
    @@ -123,11 +123,13 @@ public GLAccountData mapRow(final ResultSet rs, @SuppressWarnings("unused")
fina
             final GLAccountMapper rm = new GLAccountMapper(associationParametersData);
             String sql = "select " + rm.schema();
             // append SQL statement for fetching account totals
    -        if (associationParametersData.isRunningBalanceRequired()) {
    -            sql = sql + " and gl_j.id in (select t1.id from (select t2.account_id, max(t2.id)
as id from "
    -                    + "(select id, max(entry_date) as entry_date, account_id from acc_gl_journal_entry
where is_running_balance_calculated = 1 "
    -                    + "group by account_id desc) t3 inner join acc_gl_journal_entry t2
on t2.account_id = t3.account_id and t2.entry_date = t3.entry_date "
    -                    + "group by t2.account_id desc) t1)";
    +        if(associationParametersData!=null){
    +            if (associationParametersData.isRunningBalanceRequired()) {
    --- End diff --
    
    use both condition in one if statement


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message