Mailing-List: contact issues-help@fineract.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.apache.org
From: nazeer1100126 <git@git.apache.org>
To: issues@fineract.apache.org
Reply-To: issues@fineract.apache.org
References: <git-pr-380-fineract@git.apache.org>
In-Reply-To: <git-pr-380-fineract@git.apache.org>
Subject: [GitHub] fineract pull request #380: (FINERACT-241) Include "Add Note" to Savings Tra...
Content-Type: text/plain
Message-Id: <20170713101922.B2885F16B5@git1-us-west.apache.org>
Date: Thu, 13 Jul 2017 10:19:22 +0000 (UTC)
archived-at: Thu, 13 Jul 2017 10:19:26 -0000

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/380#discussion_r127179728
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionDataValidator.java ---
    @@ -94,6 +95,9 @@ public void validate(final JsonCommand command) {
     
             final BigDecimal transactionAmount = this.fromApiJsonHelper.extractBigDecimalWithLocaleNamed(transactionAmountParamName, element);
             baseDataValidator.reset().parameter(transactionAmountParamName).value(transactionAmount).notNull().positiveAmount();
    +		
    +		final String note = this.fromApiJsonHelper.extractStringNamed(noteParamName, element);
    --- End diff --
    
    Note can not be mandatory data. So ignore if it is null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---