Return-Path: <issues-return-925-archive-asf-public=cust-asf.ponee.io@fineract.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7D1C6200CC2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  5 Jul 2017 09:21:20 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7A6471628E9; Wed,  5 Jul 2017 07:21:20 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id E821A1628E8
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  5 Jul 2017 09:21:19 +0200 (CEST)
Received: (qmail 13552 invoked by uid 500); 5 Jul 2017 07:21:18 -0000
Mailing-List: contact issues-help@fineract.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@fineract.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@fineract.apache.org>
List-Post: <mailto:issues@fineract.apache.org>
List-Id: <issues.fineract.apache.org>
Reply-To: dev@fineract.apache.org
Delivered-To: mailing list issues@fineract.apache.org
Received: (qmail 13533 invoked by uid 99); 5 Jul 2017 07:21:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2017 07:21:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A57A3E102F; Wed,  5 Jul 2017 07:21:18 +0000 (UTC)
From: pranjal-goswami <git@git.apache.org>
To: issues@fineract.apache.org
Reply-To: issues@fineract.apache.org
References: <git-pr-376-fineract@git.apache.org>
In-Reply-To: <git-pr-376-fineract@git.apache.org>
Subject: [GitHub] fineract pull request #376: Notification Subsystem
Content-Type: text/plain
Message-Id: <20170705072118.A57A3E102F@git1-us-west.apache.org>
Date: Wed,  5 Jul 2017 07:21:18 +0000 (UTC)
archived-at: Wed, 05 Jul 2017 07:21:20 -0000

Github user pranjal-goswami commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/376#discussion_r125570163
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/eventandlistener/NotificationEventListener.java ---
    @@ -61,17 +61,7 @@ public void onMessage(Message message, Session session) throws JMSException {
     			
     			Long appUserId = notificationData.getActorId();
     			List<Long> userIds = notificationData.getUserIds();
    -			
    -			if (notificationData.getOfficeId() != null) {
    -				List<Long> tempUserIds = new ArrayList<>(userIds);
    -				for (Long userId : tempUserIds) {
    -					AppUser appUser = appUserRepository.findOne(userId);
    -					if (!Objects.equals(appUser.getOffice().getId(), notificationData.getOfficeId())) {
    -						userIds.remove(userId);
    -					}
    -				}
    -			}
    -			
    +						
     			if (userIds.contains(appUserId)) {
     				userIds.remove(appUserId);
    --- End diff --
    
    What exactly is this line doing? or what exactly is the method achieving?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---