fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] fineract pull request #380: (FINERACT-241) Include "Add Note" to Savings Tra...
Date Thu, 13 Jul 2017 10:19:22 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/380#discussion_r127177143
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -297,6 +303,12 @@ public CommandProcessingResult withdrawal(final Long savingsId, final
JsonComman
                     isRegularTransaction, isApplyWithdrawFee, isInterestTransfer, isWithdrawBalance);
             final SavingsAccountTransaction withdrawal = this.savingsAccountDomainService.handleWithdrawal(account,
fmt, transactionDate,
                     transactionAmount, paymentDetail, transactionBooleanValues);
    +				
    +		final String noteText = command.stringValueOfParameterNamed("note");
    +        if (StringUtils.isNotBlank(noteText)) {
    +            final Note note = Note.savingNote(account, noteText);
    --- End diff --
    
    need to create Note object by  savingsTransactionNote


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message