fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anh3h <...@git.apache.org>
Subject [GitHub] fineract pull request #376: Notification Subsystem
Date Wed, 05 Jul 2017 07:42:08 GMT
Github user Anh3h commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/376#discussion_r125574008
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/eventandlistener/NotificationEventListener.java
---
    @@ -61,17 +61,7 @@ public void onMessage(Message message, Session session) throws JMSException
{
     			
     			Long appUserId = notificationData.getActorId();
     			List<Long> userIds = notificationData.getUserIds();
    -			
    -			if (notificationData.getOfficeId() != null) {
    -				List<Long> tempUserIds = new ArrayList<>(userIds);
    -				for (Long userId : tempUserIds) {
    -					AppUser appUser = appUserRepository.findOne(userId);
    -					if (!Objects.equals(appUser.getOffice().getId(), notificationData.getOfficeId()))
{
    -						userIds.remove(userId);
    -					}
    -				}
    -			}
    -			
    +						
     			if (userIds.contains(appUserId)) {
     				userIds.remove(appUserId);
    --- End diff --
    
    If prevents the user who generated this notification from being notified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message