fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamrupok <...@git.apache.org>
Subject [GitHub] fineract issue #365: PR AdHocQuery API
Date Wed, 14 Jun 2017 14:32:11 GMT
Github user iamrupok commented on the issue:

    https://github.com/apache/fineract/pull/365
  
    for community-app to home should i send PR
    
    On Wed, Jun 14, 2017 at 8:27 PM, Mohammad A. rupok <iamrupok@gmail.com>
    wrote:
    
    > create a new PR #369 please review  and marge
    >
    >
    > On Wed, Jun 14, 2017 at 7:47 PM, Mohammad A. rupok <iamrupok@gmail.com>
    > wrote:
    >
    >> ok
    >>
    >> On Wed, Jun 14, 2017 at 6:49 PM, Shaik Nazeer Hussain <
    >> notifications@github.com> wrote:
    >>
    >>> *@nazeer1100126* commented on this pull request.
    >>>
    >>> I suggest not to add new changes for already reviewed PR. For now, close
    >>> this PR and send all changes with single commit.
    >>> ------------------------------
    >>>
    >>> In fineract-provider/src/main/java/org/apache/fineract/adhocque
    >>> ry/service/AdHocScheduledJobRunnerServiceImpl.java
    >>> <https://github.com/apache/fineract/pull/365#discussion_r121935446>:
    >>>
    >>> > +    private final AdHocReadPlatformService adHocReadPlatformService;
    >>> +
    >>> +    @Autowired
    >>> +    public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory
dataSourceServiceFactory,
    >>> +    		final AdHocReadPlatformService adHocReadPlatformService
    >>> +            ) {
    >>> +        this.dataSourceServiceFactory = dataSourceServiceFactory;
    >>> +        this.adHocReadPlatformService = adHocReadPlatformService;
    >>> +
    >>> +    }
    >>> +
    >>> +    @Transactional
    >>> +    @Override
    >>> +    @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
    >>> +    public void generateClientSchedule() {
    >>> +    	final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
    >>>
    >>> You can create jdbcTemplate by autowiring RoutingDataSource dataSource
    >>> in the constructor itself? Instead of creating the JDBCTemplate object here?
    >>> ------------------------------
    >>>
    >>> In fineract-provider/src/main/resources/sql/migrations/core_db/
    >>> V329__adhocquery_changes.sql
    >>> <https://github.com/apache/fineract/pull/365#discussion_r121935605>:
    >>>
    >>> > @@ -0,0 +1,21 @@
    >>> +--
    >>>
    >>> You can put this script into V328__adhocquery.sql as this PR is not yet
    >>> merged
    >>>
    >>> —
    >>> You are receiving this because you were mentioned.
    >>> Reply to this email directly, view it on GitHub
    >>> <https://github.com/apache/fineract/pull/365#pullrequestreview-44004421>,
    >>> or mute the thread
    >>> <https://github.com/notifications/unsubscribe-auth/ALCNB81xmzrZuggoMNVQexl4pAczFYPYks5sD9bcgaJpZM4N2veR>
    >>> .
    >>>
    >>
    >>
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message