fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamrupok <...@git.apache.org>
Subject [GitHub] fineract issue #362: Initial Version of AdHocQuery
Date Fri, 09 Jun 2017 07:45:22 GMT
Github user iamrupok commented on the issue:

    https://github.com/apache/fineract/pull/362
  
    Thank you for you feedback i will update accordingly.by the way
    i have added my beans appContext.xml files no error during tomcat start up
    but when i try to call the api with rest client it says
    not found.but other serivce are working .Any suggestion will be great help
    for me
    
    
    On Fri, Jun 9, 2017 at 12:21 PM, Shaik Nazeer Hussain <
    notifications@github.com> wrote:
    
    > *@nazeer1100126* requested changes on this pull request.
    > ------------------------------
    >
    > In fineract-db/adhoq.sql
    > <https://github.com/apache/fineract/pull/362#discussion_r121054204>:
    >
    > > @@ -0,0 +1,15 @@
    > +CREATE TABLE `m_adhoc` (
    >
    > This migration script should be added under fineract-provider\src\main\
    > resources\sql\migrations\core_db. and check the existing migration
    > scripts for filename format
    > ------------------------------
    >
    > In fineract-provider/src/main/java/org/apache/fineract/commands/service/
    > CommandWrapperBuilder.java
    > <https://github.com/apache/fineract/pull/362#discussion_r121055402>:
    >
    > > +        this.entityId = adHocId;
    > +        this.href = "/adhoc/" + adHocId + "/enable";
    > +        this.json = "{}";
    > +        return this;
    > +    }
    > +    public CommandWrapperBuilder createAdHoc() {
    > +        this.actionName = "CREATE";
    > +        this.entityName = "ADHOC";
    > +        this.href = "/adhoc/template";
    > +        return this;
    > +    }
    > +    public CommandWrapperBuilder updateAdHoc(final Long adHocId) {
    > +        this.actionName = "UPDATE";
    > +        this.entityName = "ADHOC";
    > +        this.entityId = adHocId;
    > +        this.href = "/roles/" + adHocId;
    >
    > why roles here? it should be adhoc?
    > ------------------------------
    >
    > In fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/
    > AdHocApiResource.java
    > <https://github.com/apache/fineract/pull/362#discussion_r121055922>:
    >
    > > +import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
    > +import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
    > +import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
    > +import org.springframework.beans.factory.annotation.Autowired;
    > +import org.springframework.context.annotation.Scope;
    > +import org.springframework.stereotype.Component;
    > +
    > +@Path("/AdhocQUery")
    > +@Component
    > +@Scope("singleton")
    > +public class AdHocApiResource {
    > +
    > +    /**
    > +     * The set of parameters that are supported in response for {@link AdhocData}
    > +     */
    > +    private final Set<String> RESPONSE_DATA_PARAMETERS = new HashSet<>(Arrays.asList("id",
"name", "query", "table_name","table_field"));
    >
    > RESPONSE_DATA_PARAMETERS should be id, name, query, tableName,
    > tableFields, isActive
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/fineract/pull/362#pullrequestreview-43073174>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ALCNB38AIgk1OxsmF1k6dQM60HW4uzKSks5sCORigaJpZM4NyxCE>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message