fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajuan <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #331: Adding validation to check not to have...
Date Fri, 21 Apr 2017 10:33:23 GMT
Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/331#discussion_r112660097
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java
---
    @@ -0,0 +1,117 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.fineract.infrastructure.security.utils;
    +
    +import java.util.StringTokenizer;
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +public class SQLInjectionValidator {
    +
    +	private final static String[] DDL_COMMANDS = { "create", "drop", "alter", "truncate",
"comment" };
    +
    +	private final static String[] DML_COMMANDS = { "select", "insert", "update", "delete",
"merge", "upsert", "call" };
    +
    +	private final static String[] COMMENTS = { "--", "({", "/*", "#" };
    +
    +	private final static String SQL_PATTERN = "[a-zA-Z_=,.'\"`% ()0-9]*";
    +
    +	public final static void validateSQLInput(final String sqlSearch) {
    +		String lowerCaseSQL = sqlSearch.toLowerCase();
    +		for (String ddl : DDL_COMMANDS) {
    +			if (lowerCaseSQL.contains(ddl)) {
    +				throw new SQLInjectionException();
    +			}
    +		}
    +
    +		for (String dml : DML_COMMANDS) {
    +			if (lowerCaseSQL.contains(dml)) {
    +				throw new SQLInjectionException();
    +			}
    +		}
    +
    +		for (String comments : COMMENTS) {
    +			if (lowerCaseSQL.contains(comments)) {
    +				throw new SQLInjectionException();
    +			}
    +		}
    +
    +		//Removing the space before and after '=' operator 
    --- End diff --
    
    Code between line 55 and 109 is futile in preventing unauthorised data access (office
hierarchy restriction)....
    For eg... it will throw an exception for string "' OR '1' = '1'"
    but not for 
    a. "a' OR '1' = '1" 
    b. "a' OR '2' != '1'"
    
    Basically we can retrieve all the data irrespective of user hierarchy restriction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message