Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
From: nazeer1100126 <git@git.apache.org>
To: issues@fineract.incubator.apache.org
Reply-To: issues@fineract.incubator.apache.org
References: <git-pr-299-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-299-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request #299: FINERACT-412 - Add Share account in Gl...
Content-Type: text/plain
Message-Id: <20170302135820.1E8A9DFAB2@git1-us-west.apache.org>
Date: Thu,  2 Mar 2017 13:58:20 +0000 (UTC)
archived-at: Thu, 02 Mar 2017 13:58:24 -0000

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/299#discussion_r103927862
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/search/data/SearchConditions.java ---
    @@ -43,18 +44,21 @@ public SearchConditions(final String searchQueryParam, final String searchResour
                     SEARCH_SUPPORTED_RESOURCES.LOANS.name().toLowerCase())) ? true : false;
             this.savingSeach = (null == searchResource || searchResource.toLowerCase().contains(
                     SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    +		this.shareSeach = (null == searchResource || searchResource.toLowerCase().contains(
    +                SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    --- End diff --
    
    shareSeach should look for SEARCH_SUPPORTED_RESOURCES.SHARES not SEARCH_SUPPORTED_RESOURCES.SAVINGS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---