fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #275: [MIFOSX-2114] Change assignment staff ...
Date Mon, 23 Jan 2017 06:13:06 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/275#discussion_r97257800
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -243,9 +243,15 @@ public CommandProcessingResult createClient(final JsonCommand command)
{
                 }
     
                 Staff staff = null;
    -            final Long staffId = command.longValueOfParameterNamed(ClientApiConstants.staffIdParamName);
    -            if (staffId != null) {
    -                staff = this.staffRepository.findByOfficeHierarchyWithNotFoundDetection(staffId,
clientOffice.getHierarchy());
    +            if (clientParentGroup != null) {
    +            	if (clientParentGroup.getParent() != null) {
    +            		staff = clientParentGroup.getParent().getStaff();
    --- End diff --
    
    If the group doesn't have any staff associated then whatever staff selected while creating
a client will be lost


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message