Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
From: abdulazizali77 <git@git.apache.org>
To: issues@fineract.incubator.apache.org
Reply-To: issues@fineract.incubator.apache.org
References: <git-pr-256-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-256-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request #256: FINERACT-7: Sort loanInstallmentCharge...
Content-Type: text/plain
Message-Id: <20161215113301.159C7E040F@git1-us-west.apache.org>
Date: Thu, 15 Dec 2016 11:33:01 +0000 (UTC)
archived-at: Thu, 15 Dec 2016 11:33:05 -0000

Github user abdulazizali77 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/256#discussion_r92592186
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java ---
    @@ -494,17 +494,29 @@ private void updateInstallmentCharges() {
                 this.loanInstallmentCharge.addAll(chargePerInstallments);
             } else {
                 int index = 0;
    -            final LoanInstallmentCharge[] loanChargePerInstallments = new LoanInstallmentCharge[chargePerInstallments.size()];
    -            final LoanInstallmentCharge[] loanChargePerInstallmentArray = chargePerInstallments.toArray(loanChargePerInstallments);
    -            for (final LoanInstallmentCharge chargePerInstallment : this.loanInstallmentCharge) {
    +            //FINERACT-7: NB: this is really overkill and slow, without changing the Sets and or Entities this is the most
    +            //locally safe way to fix this issue
    +            ArrayList<LoanInstallmentCharge> oldChargeInstallments = new ArrayList<LoanInstallmentCharge>();
    +            ArrayList<LoanInstallmentCharge> newChargeInstallments = new ArrayList<LoanInstallmentCharge>();
    +
    +            oldChargeInstallments.addAll(this.loanInstallmentCharge);
    +            newChargeInstallments.addAll(chargePerInstallments);
    +            Collections.sort(oldChargeInstallments);
    +            Collections.sort(newChargeInstallments);
    +            final LoanInstallmentCharge[] loanChargePerInstallmentArray = chargePerInstallments.toArray(new LoanInstallmentCharge[chargePerInstallments.size()]);
    --- End diff --
    
    Youre right, have modified the interface accordingly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---