fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abdulazizali77 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #256: FINERACT-7: Sort loanInstallmentCharge...
Date Tue, 06 Dec 2016 10:18:37 GMT
GitHub user abdulazizali77 opened a pull request:

    https://github.com/apache/incubator-fineract/pull/256

    FINERACT-7: Sort loanInstallmentCharges before updating

    Less than ideal fix (sorting overhead), but most topically contained. Potentially we should
change the Sets to Lists, and or redefine the Entities, but that would affect too many things.
    
    Have left a potentially iffy corner case in updateInstallmentCharges as is.
    
    Additionally there is a pre-existing defect where a PersistenceException caused by an
FK constraint is raised when all of the charges are waived. Have not investigated, potentially
there is an existing bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abdulazizali77/incubator-fineract FINERACT-7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #256
    
----
commit ebea611024d237e5388d5ba987a1798321fbd58f
Author: abdulazizali77 <abdulazizali@acm.org>
Date:   2016-12-06T10:09:03Z

    FINERACT-7: Make LoanInstallmentCharge and LoanRepaymentSchedule sortable

commit 515a4a28c8a945f35229e7f60098f010091baee3
Author: abdulazizali77 <abdulazizali@acm.org>
Date:   2016-12-06T10:10:14Z

    FINERACT-7: Sort old loanInstallmentCharges and new lic before updating

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message