fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #219: FINERACT-37 Reschedule repayment on ho...
Date Tue, 06 Sep 2016 08:06:57 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/219#discussion_r77589232
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
---
    @@ -57,10 +57,10 @@ public LocalDate generateNextRepaymentDate(final LocalDate lastRepaymentDate,
fi
                 boolean isFirstRepayment, final HolidayDetailDTO holidayDetailDTO) {
             final LocalDate firstRepaymentPeriodDate = loanApplicationTerms.getCalculatedRepaymentsStartingFromLocalDate();
             LocalDate dueRepaymentPeriodDate = null;
    +        Calendar currentCalendar = loanApplicationTerms.getLoanCalendar();
             if (isFirstRepayment && firstRepaymentPeriodDate != null) {
                 dueRepaymentPeriodDate = firstRepaymentPeriodDate;
             } else {
    -            Calendar currentCalendar = loanApplicationTerms.getLoanCalendar();
                 dueRepaymentPeriodDate = getRepaymentPeriodDate(loanApplicationTerms.getRepaymentPeriodFrequencyType(),
    --- End diff --
    
    You have removed  Calendar currentCalendar = loanApplicationTerms.getLoanCalendar(); 
    It is going to affect existing functionality


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message