Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
From: nazeer1100126 <git@git.apache.org>
To: issues@fineract.incubator.apache.org
Reply-To: issues@fineract.incubator.apache.org
References: <git-pr-209-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-209-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request #209: feature implementation of undoreject a...
Content-Type: text/plain
Message-Id: <20160816091438.CB9B2E0243@git1-us-west.apache.org>
Date: Tue, 16 Aug 2016 09:14:38 +0000 (UTC)
archived-at: Tue, 16 Aug 2016 09:14:44 -0000

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/209#discussion_r74900829
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java ---
    @@ -844,4 +844,59 @@ public CommandProcessingResult reActivateClient(Long entityId, JsonCommand comma
                     .withEntityId(entityId) //
                     .build();
         }
    -}
    \ No newline at end of file
    +
    +	@Override
    +	public CommandProcessingResult undoRejection(Long entityId, JsonCommand command) {
    +		final AppUser currentUser = this.context.authenticatedUser();
    +		this.fromApiJsonDeserializer.validateUndoRejection(command);
    +
    +		final Client client = this.clientRepository.findOneWithNotFoundDetection(entityId);
    +		final LocalDate undoRejectDate = command
    +				.localDateValueOfParameterNamed(ClientApiConstants.reopenedDateParamName);
    +
    +		if (!client.isRejected()) {
    --- End diff --
    
    This validation logic can be moved to validator


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---