Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
From: nazeer1100126 <git@git.apache.org>
To: issues@fineract.incubator.apache.org
Reply-To: issues@fineract.incubator.apache.org
References: <git-pr-195-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-195-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request #195: address_module
Content-Type: text/plain
Message-Id: <20160809043155.3F90ADFB38@git1-us-west.apache.org>
Date: Tue,  9 Aug 2016 04:31:55 +0000 (UTC)
archived-at: Tue, 09 Aug 2016 04:32:01 -0000

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/195#discussion_r73996647
  
    --- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/v312_address_module_tables_metadat.sql ---
    @@ -0,0 +1,124 @@
    +--
    +-- Licensed to the Apache Software Foundation (ASF) under one
    +-- or more contributor license agreements. See the NOTICE file
    +-- distributed with this work for additional information
    +-- regarding copyright ownership. The ASF licenses this file
    +-- to you under the Apache License, Version 2.0 (the
    +-- "License"); you may not use this file except in compliance
    +-- with the License. You may obtain a copy of the License at
    +--
    +-- http://www.apache.org/licenses/LICENSE-2.0
    +--
    +-- Unless required by applicable law or agreed to in writing,
    +-- software distributed under the License is distributed on an
    +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +-- KIND, either express or implied. See the License for the
    +-- specific language governing permissions and limitations
    +-- under the License.
    +--
    +
    +--code inserts
    +INSERT INTO `m_code` (`id`, `code_name`, `is_system_defined`) VALUES (150, 'INDIAN STATES', 0);
    --- End diff --
    
    You should not insert id as they are auto incremented and the insert will fail if m_code table already has these ids


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---