fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <>
Subject [GitHub] incubator-fineract pull request #199: commit for FINERACT-72 (Speed up the r...
Date Fri, 12 Aug 2016 04:25:37 GMT
Github user nazeer1100126 commented on a diff in the pull request:
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/
    @@ -889,12 +890,13 @@ private void createDebitJournalEntryForLoan(final Office office,
final String cu
             LoanTransaction loanTransaction = null;
             SavingsAccountTransaction savingsAccountTransaction = null;
             ClientTransaction clientTransaction = null;
    -        final PaymentDetail paymentDetail = null;
    +        PaymentDetail paymentDetail = null;
             final Long shareTransactionId = null;
             String modifiedTransactionId = transactionId;
             if (StringUtils.isNumeric(transactionId)) {
                 long id = Long.parseLong(transactionId);
                 loanTransaction = this.loanTransactionRepository.findOne(id);
    +            paymentDetail = this.loanTransactionRepository.findOne(id).getPaymentDetail();
    --- End diff --
    unnecessary repository call. You can make use of loanTransaction object to retrieve payment

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message