fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #195: address_module
Date Tue, 09 Aug 2016 05:20:24 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/195#discussion_r73999278
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/api/GlobalConfigurationApiResource.java
---
    @@ -76,29 +76,44 @@ public GlobalConfigurationApiResource(final PlatformSecurityContext
context,
         @GET
         @Consumes({ MediaType.APPLICATION_JSON })
         @Produces({ MediaType.APPLICATION_JSON })
    -    public String retrieveConfiguration(@Context final UriInfo uriInfo,@DefaultValue("false")
@QueryParam("survey") final boolean survey) {
    +    public String retrieveConfiguration(@Context final UriInfo uriInfo,
    --- End diff --
    
    I don't know whether you have followed our discussion. Let me put it here what I understood.
You are supposed to add a new method in read platform service. Not in the API resource. Let
me know if you differ this :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message