fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <>
Subject [GitHub] incubator-fineract pull request #192: commit FINERACT-54 (Add ability to del...
Date Wed, 03 Aug 2016 11:54:43 GMT
Github user nazeer1100126 commented on a diff in the pull request:
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/api/
    @@ -86,11 +88,16 @@ public CodeValuesApiResource(final PlatformSecurityContext context,
final CodeVa
         @Consumes({ MediaType.APPLICATION_JSON })
         @Produces({ MediaType.APPLICATION_JSON })
    -    public String retrieveAllCodeValues(@Context final UriInfo uriInfo, @PathParam("codeId")
final Long codeId) {
    +    public String retrieveAllCodeValues(@Context final UriInfo uriInfo, @PathParam("codeId")
final Long codeId, 
    +            @QueryParam("includeDeletedCodeValues") final String includeDeletedCodeValues)
    -        final Collection<CodeValueData> codeValues = this.readPlatformService.retrieveAllCodeValues(codeId);
    +        Collection<CodeValueData> codeValues = this.readPlatformService.retrieveAllActiveCodeValues(codeId);
    --- End diff --
    avoid multiple DB calls when includeDeletedCodeValues is true 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message