fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #191: commit for FINERACT-65 (Implement abil...
Date Wed, 03 Aug 2016 07:25:43 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/191#discussion_r73291714
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java
---
    @@ -2736,4 +2736,27 @@ public CommandWrapperBuilder deleteSelfServiceBeneficiaryTPT(final
Long benefici
             return this;
     	}
     
    -}
    \ No newline at end of file
    +	public CommandWrapperBuilder createReportMailingJob(final String entityName) {
    +        this.actionName = "CREATE";
    +        this.entityName = entityName;
    +        this.entityId = null;
    +        this.href = "/reportmailingjobs";
    +        return this;
    +    }
    +    
    +    public CommandWrapperBuilder updateReportMailingJob(final String entityName, final
Long entityId) {
    +        this.actionName = "UPDATE";
    +        this.entityName = entityName;
    +        this.entityId = entityId;
    +        this.href = "/reportmailingjobs/" + entityId;
    +        return this;
    +    }
    +    
    +    public CommandWrapperBuilder deleteReportMailingJob(final String entityName, final
Long entityId) {
    --- End diff --
    
    Caller is passing permission name and entity id. But you are assigning permission name
to entity name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message