fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #191: commit for FINERACT-65 (Implement abil...
Date Wed, 03 Aug 2016 07:02:07 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/191#discussion_r73289454
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportRepositoryWrapper.java
---
    @@ -0,0 +1,61 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.fineract.infrastructure.dataqueries.domain;
    +
    +import org.apache.fineract.infrastructure.dataqueries.exception.ReportNotFoundException;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.stereotype.Service;
    +
    +/** 
    + *  A wrapper class for the ReportRepository that provides a method that returns a Report
entity if it exists, 
    + *  else throws "ReportNotFoundException" exception if the Report does not exist
    + **/
    +@Service
    +public class ReportRepositoryWrapper {
    +    private final ReportRepository reportRepository;
    +    
    +    @Autowired
    +    public ReportRepositoryWrapper(final ReportRepository reportRepository) {
    +        this.reportRepository = reportRepository;
    +    }
    +    
    +    /**
    +     * Retrieves an entity by its id
    +     * 
    +     * @param id must not be null
    +     * @throws ReportNotFoundException if entity not found
    +     * @return {@link Report} object
    +     */
    +    public Report findOneThrowExceptionIfNotFound(final Long id) {
    +        final Report report = this.reportRepository.findOne(id);
    +        
    +        if (report == null) {
    +            throw new ReportNotFoundException(id);
    +        }
    +        
    +        return report;
    +    }
    +    
    +    /**
    +     * @return {@link ReportRepository} object
    +     */
    +    public ReportRepository getReportRepository() {
    --- End diff --
    
    I don't see any references to this method. Is this method required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message