fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emmanuelnnaa <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #175: commit for FINERACT-51 (Add the 'is_re...
Date Tue, 02 Aug 2016 15:28:52 GMT
Github user emmanuelnnaa commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/175#discussion_r73178254
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
---
    @@ -247,7 +247,7 @@ public LoanScheduleData retrieveRepaymentSchedule(final Long loanId,
                  ***/
                 final String sql = "select "
                         + rm.LoanPaymentsSchema()
    -                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0,
3) and  (tr.is_reversed=0 or tr.manually_adjusted_or_reversed = 1) order by tr.transaction_date
ASC,id ";
    +                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0,
3) and  (tr.is_reversed=0 or tr.is_reversed = 1) order by tr.transaction_date ASC,id ";
    --- End diff --
    
    @nazeer1100126 
    The main reason for the change was to have the query return all results (both system reversed
and manually reversed). That can also be achieved without the following line "and  (tr.is_reversed=0
or tr.is_reversed = 1)". Consequently, I will remove the above line and create a new pull
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message