fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emmanuelnnaa <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #176: commit for FINERACT-52 (Null value not...
Date Tue, 02 Aug 2016 14:09:36 GMT
Github user emmanuelnnaa commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/176#discussion_r73161469
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -631,7 +631,7 @@ public CommandProcessingResult closeClient(final Long clientId, final
JsonComman
                     throw new InvalidClientStateTransitionException("close", "is.under.transfer",
errorMessage);
                 }
     
    -            if (client.isNotPending() && client.getActivationLocalDate().isAfter(closureDate))
{
    +            if (client.isNotPending() && client.getActivationLocalDate() != null
&& client.getActivationLocalDate().isAfter(closureDate)) {
    --- End diff --
    
    @nazeer1100126 
    There's no guarantee that the "activationDate" property of all clients will have a value
other than NULL or an empty string. During migration of a new tenant, some data might be missed.
Moreover, it is good practice to carry out such checks to avoid null pointer exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message