fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikpawar89 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #189: address_module
Date Mon, 01 Aug 2016 14:55:10 GMT
Github user nikpawar89 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/189#discussion_r72992036
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/service/ShareAccountCommandsServiceImpl.java
---
    @@ -47,7 +47,7 @@ public ShareAccountCommandsServiceImpl(final FromJsonHelper fromApiJsonHelper,
         public Object handleCommand(Long accountId, String command, String jsonBody) {
             final JsonElement parsedCommand = this.fromApiJsonHelper.parse(jsonBody);
             final JsonCommand jsonCommand = JsonCommand.from(jsonBody, parsedCommand, this.fromApiJsonHelper,
null, null, null, null, null,
    -                null, null, null, null, null);
    +                null, null, null, null, null,null);
    --- End diff --
    
    from static method of JsonCommand class has to be chaned in order to get status value
from the JSONCommand.  The change in the signature results in addition of one more parameter
value in this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message