Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
From: nazeer1100126 <git@git.apache.org>
To: issues@fineract.incubator.apache.org
Reply-To: issues@fineract.incubator.apache.org
References: <git-pr-170-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-170-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request #170: commit for FINERACT-46 (Throw an excep...
Content-Type: text/plain
Message-Id: <20160728105708.312ECE0100@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 10:57:08 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 10:57:13 -0000

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/170#discussion_r72602036
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/staff/service/StaffWritePlatformServiceJpaRepositoryImpl.java ---
    @@ -91,6 +92,17 @@ public CommandProcessingResult updateStaff(final Long staffId, final JsonCommand
     
                 final Staff staffForUpdate = this.staffRepository.findOne(staffId);
                 if (staffForUpdate == null) { throw new StaffNotFoundException(staffId); }
    +            
    +            final boolean isActive = command.booleanPrimitiveValueOfParameterNamed("isActive");
    +            
    +            if(staffForUpdate.isActive() && !isActive) {
    +                final boolean isAnyActiveEntityAssociatedWithStaff = this.staffRepository.
    --- End diff --
    
    Use StaffReadPlatformService instead of repository


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---