fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #176: commit for FINERACT-52 (Null value not...
Date Fri, 29 Jul 2016 09:16:42 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/176#discussion_r72763455
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -631,7 +631,7 @@ public CommandProcessingResult closeClient(final Long clientId, final
JsonComman
                     throw new InvalidClientStateTransitionException("close", "is.under.transfer",
errorMessage);
                 }
     
    -            if (client.isNotPending() && client.getActivationLocalDate().isAfter(closureDate))
{
    +            if (client.isNotPending() && client.getActivationLocalDate() != null
&& client.getActivationLocalDate().isAfter(closureDate)) {
    --- End diff --
    
    Instead of checking activation date to null why can't we add a check if client status
is active and client activation date is after closure date?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message