Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8AEB4200B27 for ; Wed, 22 Jun 2016 11:40:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 89914160A35; Wed, 22 Jun 2016 09:40:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D24AD160A2E for ; Wed, 22 Jun 2016 11:40:51 +0200 (CEST) Received: (qmail 28920 invoked by uid 500); 22 Jun 2016 09:40:51 -0000 Mailing-List: contact issues-help@fineract.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.incubator.apache.org Delivered-To: mailing list issues@fineract.incubator.apache.org Received: (qmail 28911 invoked by uid 99); 22 Jun 2016 09:40:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2016 09:40:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A8AB61A5309 for ; Wed, 22 Jun 2016 09:40:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id tRKQ8w3akuVo for ; Wed, 22 Jun 2016 09:40:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 89F335F4E5 for ; Wed, 22 Jun 2016 09:40:48 +0000 (UTC) Received: (qmail 28860 invoked by uid 99); 22 Jun 2016 09:40:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2016 09:40:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B9337DFEDA; Wed, 22 Jun 2016 09:40:47 +0000 (UTC) From: terencemo To: issues@fineract.incubator.apache.org Reply-To: issues@fineract.incubator.apache.org Message-ID: Subject: [GitHub] incubator-fineract pull request #154: Fixed client share activated user join Content-Type: text/plain Date: Wed, 22 Jun 2016 09:40:47 +0000 (UTC) archived-at: Wed, 22 Jun 2016 09:40:52 -0000 GitHub user terencemo opened a pull request: https://github.com/apache/incubator-fineract/pull/154 Fixed client share activated user join When getting share account list under a client, if ```rejected_userid``` is set for the share account, the join condition for ```activated_userid``` was using the rejected user table in the join condition resulting in multiple instances of share account records which have both these columns set. Also the activated user details are incorrectly returned in the resultset. The fix uses the correct table alias avbu in the join condition instead of rbu and so removes duplicate records and ensures correct activated user details are returned. You can merge this pull request into a Git repository by running: $ git pull https://github.com/terencemo/incubator-fineract i190-multi-shareac Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-fineract/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 ---- commit 34353938a7788520c53f07ff95fef9862d9cf539 Author: Terence Monteiro Date: 2016-06-22T08:32:22Z Fixed client share activated user join ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---