fineract-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #152: FINERACT-186 batch job optimisation
Date Wed, 22 Jun 2016 11:57:03 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/152#discussion_r68039658
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularServiceImpl.java
---
    @@ -30,47 +30,57 @@
     import org.apache.fineract.portfolio.savings.domain.SavingsAccountStatusType;
     import org.joda.time.LocalDate;
     import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.data.domain.Page;
    +import org.springframework.data.domain.PageRequest;
     import org.springframework.stereotype.Service;
     
     @Service
     public class SavingsSchedularServiceImpl implements SavingsSchedularService {
     
         private final SavingsAccountAssembler savingAccountAssembler;
         private final SavingsAccountWritePlatformService savingsAccountWritePlatformService;
    -    private final SavingsAccountRepository savingAccountRepository;
         private final SavingsAccountReadPlatformService savingAccountReadPlatformService;
    +    private final SavingsAccountRepository savingsAccountRepository;
     
         @Autowired
         public SavingsSchedularServiceImpl(final SavingsAccountAssembler savingAccountAssembler,
                 final SavingsAccountWritePlatformService savingsAccountWritePlatformService,
    -            final SavingsAccountRepository savingAccountRepository,
    -            final SavingsAccountReadPlatformService savingAccountReadPlatformService)
{
    +            final SavingsAccountReadPlatformService savingAccountReadPlatformService,
    +            final SavingsAccountRepository savingsAccountRepository) {
             this.savingAccountAssembler = savingAccountAssembler;
             this.savingsAccountWritePlatformService = savingsAccountWritePlatformService;
    -        this.savingAccountRepository = savingAccountRepository;
             this.savingAccountReadPlatformService = savingAccountReadPlatformService;
    +        this.savingsAccountRepository = savingsAccountRepository;
         }
     
         @CronTarget(jobName = JobName.POST_INTEREST_FOR_SAVINGS)
         @Override
         public void postInterestForAccounts() throws JobExecutionException {
    -        final List<SavingsAccount> savingsAccounts = this.savingAccountRepository.findSavingAccountByStatus(SavingsAccountStatusType.ACTIVE
    -                .getValue());
    +        int offSet = 0;
    --- End diff --
    
    Can you rename offSet to page. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message