Mailing-List: contact dev-help@fineract.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.apache.org
Date: Thu, 13 Jul 2017 10:20:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@fineract.incubator.apache.org
Message-ID: <JIRA.13013897.1476973185000.238179.1499941200274@Atlassian.JIRA>
In-Reply-To: <JIRA.13013897.1476973185000@Atlassian.JIRA>
References: <JIRA.13013897.1476973185000@Atlassian.JIRA> <JIRA.13013897.1476973185496@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and
 Withdrawal screen in savings account
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 13 Jul 2017 10:20:06 -0000


    [ https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085513#comment-16085513 ] 

ASF GitHub Bot commented on FINERACT-241:
-----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/380#discussion_r127177143
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountWritePlatformServiceJpaRepositoryImpl.java ---
    @@ -297,6 +303,12 @@ public CommandProcessingResult withdrawal(final Long savingsId, final JsonComman
                     isRegularTransaction, isApplyWithdrawFee, isInterestTransfer, isWithdrawBalance);
             final SavingsAccountTransaction withdrawal = this.savingsAccountDomainService.handleWithdrawal(account, fmt, transactionDate,
                     transactionAmount, paymentDetail, transactionBooleanValues);
    +				
    +		final String noteText = command.stringValueOfParameterNamed("note");
    +        if (StringUtils.isNotBlank(noteText)) {
    +            final Note note = Note.savingNote(account, noteText);
    --- End diff --
    
    need to create Note object by  savingsTransactionNote


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> ----------------------------------------------------------------------
>
>                 Key: FINERACT-241
>                 URL: https://issues.apache.org/jira/browse/FINERACT-241
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Dayna Harp
>            Assignee: Markus Geiss
>              Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so that narration can be added especially name of the person who has deposited which may not be necessarily the account holder. Its good for controls and follow ups.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)