fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FINERACT-241) Include "Add Note" to Deposit and Withdrawal screen in savings account
Date Thu, 13 Jul 2017 10:20:00 GMT

    [ https://issues.apache.org/jira/browse/FINERACT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085512#comment-16085512
] 

ASF GitHub Bot commented on FINERACT-241:
-----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/380#discussion_r127177079
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -254,6 +254,12 @@ public CommandProcessingResult deposit(final Long savingsId, final
JsonCommand c
             boolean isRegularTransaction = true;
             final SavingsAccountTransaction deposit = this.savingsAccountDomainService.handleDeposit(account,
fmt, transactionDate,
                     transactionAmount, paymentDetail, isAccountTransfer, isRegularTransaction);
    +				
    +		final String noteText = command.stringValueOfParameterNamed("note");
    +        if (StringUtils.isNotBlank(noteText)) {
    +            final Note note = Note.savingNote(account, noteText);
    --- End diff --
    
    need to create Note object by  savingsTransactionNote


> Include "Add Note" to Deposit and Withdrawal screen in savings account
> ----------------------------------------------------------------------
>
>                 Key: FINERACT-241
>                 URL: https://issues.apache.org/jira/browse/FINERACT-241
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Dayna Harp
>            Assignee: Markus Geiss
>              Labels: beginner, p3
>
> https://mifosforge.jira.com/browse/MIFOSX-2620
> Refer to MIFOSX for images
> Include "Add Note" to Deposit and Withdrawal screen in savings account so that narration
can be added especially name of the person who has deposited which may not be necessarily
the account holder. Its good for controls and follow ups.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message