Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D07B7200B7E for ; Tue, 6 Sep 2016 11:56:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CEE38160ABF; Tue, 6 Sep 2016 09:56:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21052160AAD for ; Tue, 6 Sep 2016 11:56:26 +0200 (CEST) Received: (qmail 81061 invoked by uid 500); 6 Sep 2016 09:56:26 -0000 Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.incubator.apache.org Delivered-To: mailing list dev@fineract.incubator.apache.org Received: (qmail 81046 invoked by uid 99); 6 Sep 2016 09:56:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2016 09:56:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B90C9C05BE for ; Tue, 6 Sep 2016 09:56:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 39L3W0SAqEwo for ; Tue, 6 Sep 2016 09:56:23 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id C36BC5FBE4 for ; Tue, 6 Sep 2016 09:56:22 +0000 (UTC) Received: (qmail 80356 invoked by uid 99); 6 Sep 2016 09:56:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2016 09:56:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EB5602C1B79 for ; Tue, 6 Sep 2016 09:56:21 +0000 (UTC) Date: Tue, 6 Sep 2016 09:56:21 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@fineract.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Sep 2016 09:56:28 -0000 [ https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467008#comment-15467008 ] ASF GitHub Bot commented on FINERACT-37: ---------------------------------------- Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/219#discussion_r77605384 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final LocalDate lastRepaymentDate, fi loanApplicationTerms.getNumberOfdays()); } } - + if (currentCalendar == null && holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) { --- End diff -- if extendTermForRepaymentsOnHolidays is true, why can't we call adjustRepaymentDate method and return that date? > Support rescheduling repayments on holidays > ------------------------------------------- > > Key: FINERACT-37 > URL: https://issues.apache.org/jira/browse/FINERACT-37 > Project: Apache Fineract > Issue Type: Improvement > Components: System > Reporter: James Rowe > Assignee: Markus Geiss > > Our client is currently trying to migrate from their current financial software, but one of the configuration options is not present in Fineract. The option changes the way Fineract schedules loan repayments. Instead of rescheduling a repayment to a different day in the week, holidays would reschedule the repayment to the next due date and extend the schedule. For example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that has a repayment fall in the holiday will be rescheduled to the next week and the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png With this the loan term is extended and the repayment that landed on a holiday is repaid on the next due date. > I already have a proof of concept patch for this, but I think there are some issues with it. As such, I would like to work with a developer to discuss the best way to implement this, or if you would like, we can just figure out why my patch occasionally enters an infinite loop... > As a related request, the client is looking to have the interest due at this repayment to be redistributed across the full loan schedule. I wasn't sure if I should include this in this issue report or to make a new one that is related to this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)