Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36E7F200B64 for ; Tue, 2 Aug 2016 17:29:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 35750160A76; Tue, 2 Aug 2016 15:29:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7EDB4160A65 for ; Tue, 2 Aug 2016 17:29:26 +0200 (CEST) Received: (qmail 41055 invoked by uid 500); 2 Aug 2016 15:29:25 -0000 Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.incubator.apache.org Delivered-To: mailing list dev@fineract.incubator.apache.org Received: (qmail 41044 invoked by uid 99); 2 Aug 2016 15:29:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 15:29:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D1FFF1A60B0 for ; Tue, 2 Aug 2016 15:29:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qRR_f1s3UEDb for ; Tue, 2 Aug 2016 15:29:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id D31E75FAEE for ; Tue, 2 Aug 2016 15:29:21 +0000 (UTC) Received: (qmail 40437 invoked by uid 99); 2 Aug 2016 15:29:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 15:29:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F39B02C0033 for ; Tue, 2 Aug 2016 15:29:20 +0000 (UTC) Date: Tue, 2 Aug 2016 15:29:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@fineract.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FINERACT-51) Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 Aug 2016 15:29:27 -0000 [ https://issues.apache.org/jira/browse/FINERACT-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404187#comment-15404187 ] ASF GitHub Bot commented on FINERACT-51: ---------------------------------------- Github user emmanuelnnaa commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/175#discussion_r73178254 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java --- @@ -247,7 +247,7 @@ public LoanScheduleData retrieveRepaymentSchedule(final Long loanId, ***/ final String sql = "select " + rm.LoanPaymentsSchema() - + " where tr.loan_id = ? and tr.transaction_type_enum not in (0, 3) and (tr.is_reversed=0 or tr.manually_adjusted_or_reversed = 1) order by tr.transaction_date ASC,id "; + + " where tr.loan_id = ? and tr.transaction_type_enum not in (0, 3) and (tr.is_reversed=0 or tr.is_reversed = 1) order by tr.transaction_date ASC,id "; --- End diff -- @nazeer1100126 The main reason for the change was to have the query return all results (both system reversed and manually reversed). That can also be achieved without the following line "and (tr.is_reversed=0 or tr.is_reversed = 1)". Consequently, I will remove the above line and create a new pull request. > Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object > ------------------------------------------------------------------------------------------------- > > Key: FINERACT-51 > URL: https://issues.apache.org/jira/browse/FINERACT-51 > Project: Apache Fineract > Issue Type: Improvement > Reporter: Emmanuel Nnaa > Assignee: Markus Geiss > Priority: Minor > > Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)