fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true
Date Fri, 12 Aug 2016 04:26:20 GMT

    [ https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418348#comment-15418348
] 

ASF GitHub Bot commented on FINERACT-72:
----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/199#discussion_r74540164
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java
---
    @@ -889,12 +890,13 @@ private void createDebitJournalEntryForLoan(final Office office,
final String cu
             LoanTransaction loanTransaction = null;
             SavingsAccountTransaction savingsAccountTransaction = null;
             ClientTransaction clientTransaction = null;
    -        final PaymentDetail paymentDetail = null;
    +        PaymentDetail paymentDetail = null;
             final Long shareTransactionId = null;
             String modifiedTransactionId = transactionId;
             if (StringUtils.isNumeric(transactionId)) {
                 long id = Long.parseLong(transactionId);
                 loanTransaction = this.loanTransactionRepository.findOne(id);
    +            paymentDetail = this.loanTransactionRepository.findOne(id).getPaymentDetail();
    --- End diff --
    
    unnecessary repository call. You can make use of loanTransaction object to retrieve payment
details 


> Speed up the retrieval of journal entries when "transactionDetails" is set to true
> ----------------------------------------------------------------------------------
>
>                 Key: FINERACT-72
>                 URL: https://issues.apache.org/jira/browse/FINERACT-72
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the "transactionDetails"
parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message