fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FINERACT-65) Implement ability to schedule & e-mail reports
Date Wed, 03 Aug 2016 07:02:20 GMT

    [ https://issues.apache.org/jira/browse/FINERACT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405446#comment-15405446
] 

ASF GitHub Bot commented on FINERACT-65:
----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/191#discussion_r73289454
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportRepositoryWrapper.java
---
    @@ -0,0 +1,61 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.fineract.infrastructure.dataqueries.domain;
    +
    +import org.apache.fineract.infrastructure.dataqueries.exception.ReportNotFoundException;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.stereotype.Service;
    +
    +/** 
    + *  A wrapper class for the ReportRepository that provides a method that returns a Report
entity if it exists, 
    + *  else throws "ReportNotFoundException" exception if the Report does not exist
    + **/
    +@Service
    +public class ReportRepositoryWrapper {
    +    private final ReportRepository reportRepository;
    +    
    +    @Autowired
    +    public ReportRepositoryWrapper(final ReportRepository reportRepository) {
    +        this.reportRepository = reportRepository;
    +    }
    +    
    +    /**
    +     * Retrieves an entity by its id
    +     * 
    +     * @param id must not be null
    +     * @throws ReportNotFoundException if entity not found
    +     * @return {@link Report} object
    +     */
    +    public Report findOneThrowExceptionIfNotFound(final Long id) {
    +        final Report report = this.reportRepository.findOne(id);
    +        
    +        if (report == null) {
    +            throw new ReportNotFoundException(id);
    +        }
    +        
    +        return report;
    +    }
    +    
    +    /**
    +     * @return {@link ReportRepository} object
    +     */
    +    public ReportRepository getReportRepository() {
    --- End diff --
    
    I don't see any references to this method. Is this method required?


> Implement ability to schedule & e-mail reports
> ----------------------------------------------
>
>                 Key: FINERACT-65
>                 URL: https://issues.apache.org/jira/browse/FINERACT-65
>             Project: Apache Fineract
>          Issue Type: New Feature
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>            Priority: Minor
>
> Some reports take a bit longer to run, therefore we should be able to allow our users
to schedule them overnight to be e-mailed. 
> The way this should work is:
> - Add e-mailaddress to users and make it mandatory (possibly already in MifosX)
> - Allow users to configure schedule entries which consist of:
> - One or multiple target users (e-mailaddresses)
> - Set the preferred subject and content of the e-mail (Look at user generated documents
API in MifosX for replacing certain variables)
> - Choose the run frequency of the report (daily, weekly, every x'th day of the month
etc, cron-like flexibility with a UI)
> - Pick the preferred output format (PDF/XLS/CSV)
> These reports should be picked up by a scheduled job overnight and then run in serial
to avoid performance hits and sent out to the users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message