fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FINERACT-51) Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object
Date Tue, 02 Aug 2016 15:29:20 GMT

    [ https://issues.apache.org/jira/browse/FINERACT-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404187#comment-15404187
] 

ASF GitHub Bot commented on FINERACT-51:
----------------------------------------

Github user emmanuelnnaa commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/175#discussion_r73178254
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
---
    @@ -247,7 +247,7 @@ public LoanScheduleData retrieveRepaymentSchedule(final Long loanId,
                  ***/
                 final String sql = "select "
                         + rm.LoanPaymentsSchema()
    -                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0,
3) and  (tr.is_reversed=0 or tr.manually_adjusted_or_reversed = 1) order by tr.transaction_date
ASC,id ";
    +                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0,
3) and  (tr.is_reversed=0 or tr.is_reversed = 1) order by tr.transaction_date ASC,id ";
    --- End diff --
    
    @nazeer1100126 
    The main reason for the change was to have the query return all results (both system reversed
and manually reversed). That can also be achieved without the following line "and  (tr.is_reversed=0
or tr.is_reversed = 1)". Consequently, I will remove the above line and create a new pull
request.


> Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData"
object
> -------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-51
>                 URL: https://issues.apache.org/jira/browse/FINERACT-51
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>            Priority: Minor
>
> Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData"
object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message