Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fineract.incubator.apache.org
Date: Fri, 29 Jul 2016 09:09:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@fineract.incubator.apache.org
Message-ID: <JIRA.12945779.1456823325000.167033.1469783360444@Atlassian.JIRA>
In-Reply-To: <JIRA.12945779.1456823325000@Atlassian.JIRA>
References: <JIRA.12945779.1456823325000@Atlassian.JIRA> <JIRA.12945779.1456823325156@arcas>
Subject: [jira] [Commented] (FINERACT-51) Add the "is_reversed" property of
 the loan transaction entity to the "LoanTransactionData" object
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Jul 2016 09:09:23 -0000


    [ https://issues.apache.org/jira/browse/FINERACT-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399010#comment-15399010 ] 

ASF GitHub Bot commented on FINERACT-51:
----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/175#discussion_r72762541
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java ---
    @@ -247,7 +247,7 @@ public LoanScheduleData retrieveRepaymentSchedule(final Long loanId,
                  ***/
                 final String sql = "select "
                         + rm.LoanPaymentsSchema()
    -                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0, 3) and  (tr.is_reversed=0 or tr.manually_adjusted_or_reversed = 1) order by tr.transaction_date ASC,id ";
    +                    + " where tr.loan_id = ? and tr.transaction_type_enum not in (0, 3) and  (tr.is_reversed=0 or tr.is_reversed = 1) order by tr.transaction_date ASC,id ";
    --- End diff --
    
    what happens if manually_adjusted_or_reversed=0 or 1?


> Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object
> -------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-51
>                 URL: https://issues.apache.org/jira/browse/FINERACT-51
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>            Priority: Minor
>
> Add the "is_reversed" property of the loan transaction entity to the "LoanTransactionData" object.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)