fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament"<johndam...@apache.org>
Subject Re: [VOTE] [FINERACT] 0.3.2-incubating for release
Date Wed, 13 Jul 2016 23:54:47 GMT
Nazeer,

Can you tell me what command you use to build?  Even if its a script issue, I'm concerned
that you're able to get a non-compliant binary from the source.

John

On 2016-07-12 23:50 (-0400), Nazeer Shaik <nazeer.shaik@confluxtechnologies.com> wrote:

> Strange. Are you sure you are seeing hibernate entity manager in binary? If
> you are seeing Hibernate validator, then it is Apache Licensed. I believe
> it wont be a problem. MySQL JDBC Driver dependency is commented. So it
> won't download this dependency.
> 
> Thank you very much for your time for us. Just now I have verified again, I
> don't see hibernate entity manager dependency and I don't see MySQL JDBC
> connetor is getting included in the binary.
> 
> Nazeer
> 
> 
> On Wed, Jul 13, 2016 at 8:53 AM, John D. Ament <johndament@apache.org>
> wrote:
> 
> > Hi Nazeer,
> >
> > I think we're disconnected a little bit.  Following your readme file, I
> > ran "gradle clean war" (Note: I have gradle preinstalled).  The resulting
> > binary zip includes hibernate as a dependency.  In addition, I see the
> > MySQL JDBC Driver in as a dependency, which is GPL.
> >
> > John
> >
> > On 2016-07-12 21:48 (-0400), Nazeer Shaik <
> > nazeer.shaik@confluxtechnologies.com> wrote:
> > > Hi John,
> > >
> > > We are removing hibernate transitive dependency by adding following
> > script
> > > in build.gradle.
> > >
> > > compile() {
> > >         exclude module: 'hibernate-entitymanager'
> > > }
> > >
> > > Thanks,
> > > Nazeer
> > >
> > >
> > > On Wed, Jul 13, 2016 at 7:04 AM, John D. Ament <johndament@apache.org>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > Just to point this out - hope you don't mind my lurking.  You still
> > have a
> > > > dependency on hibernate transitively from spring-boot-starter-data-jpa.
> > > >
> > > > John
> > > >
> > > > On 2016-07-12 10:32 (-0400), Nazeer Shaik <nazeer1100126@apache.org>
> > > > wrote:
> > > > > Hello Fineract community,
> > > > >
> > > > > We have created 0.3.2-incubating release, with the artifacts below
up
> > > > for a
> > > > > vote.
> > > > >
> > > > > These are the goals of this release:
> > > > >
> > > > >    - Moved Hibernate dependency only to integration tests. So default
> > > > build
> > > > >    will not include Hibernate dependency
> > > > >    - Removed JSR305 dependency
> > > > >
> > > > >
> > > > > *For more information including release notes, please see:*
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/FINERACT/0.3.2+Release-+Apache+Fineract
> > > > >
> > > > > This is a *source code tar ball* only release.
> > > > >
> > > > > *** Please download, review and vote by Thu July 14, 2016 @ 6pm PST
> > ***
> > > > >
> > > > > *Source Files:*
> > > > >
> > > >
> > https://dist.apache.org/repos/dist/dev/incubator/fineract/0.3.2-incubating/
> > > > >
> > > > > *Commit to be voted on:*
> > > > >
> > > >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-fineract.git;a=commit;h=refs/heads/0.3.2-incubating
> > > > >
> > > > > *Build verification steps can be found at: *
> > > > > Refer 'README.md' in apache-fineract-0.3.2-incubating-src.tar.gz
> > > > >
> > > > > *KEYS file containing PGP Keys we use to sign the release:*
> > > > > https://dist.apache.org/repos/dist/dev/incubator/fineract/KEYS
> > > > >
> > > > >
> > > > > *Note: *
> > > > >
> > > > >    - This is a source only release with no binaries, with
> > instructions on
> > > > >    how to build/test the application.
> > > > >    - We use hibernate for integration tests only and doesn't include
> > any
> > > > >    source or binary from Hibernate
> > > > >    - There is a *change in command to run integration tests*. Please
> > look
> > > > >    at README.md for more details.
> > > > >
> > > > > To help in tallying the vote, members please be sure to indicate
> > > > > "(binding)" with your vote.
> > > > >
> > > > > [ ] +1  approve
> > > > > [ ] +0  no opinion
> > > > > [ ] -1  disapprove (and reason why)
> > > > >
> > > > > Thank you,
> > > > > Nazeer
> > > > >
> > > >
> > >
> >
> 

Mime
View raw message