fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FINERACT-44) Cannot delete an inactive charge associated with a product (loan/savings)
Date Thu, 14 Jul 2016 13:34:20 GMT

    [ https://issues.apache.org/jira/browse/FINERACT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376918#comment-15376918
] 

ASF GitHub Bot commented on FINERACT-44:
----------------------------------------

GitHub user emmanuelnnaa opened a pull request:

    https://github.com/apache/incubator-fineract/pull/168

    commit for FINERACT-44 (Cannot delete an inactive charge associated with a product (loan/savings))

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/emmanuelnnaa/incubator-fineract FINERACT-44

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
    
----
commit 65df32c4449a0f6e2e29c54b9494b32841f5825e
Author: Emmanuel Nnaa <emmanuelnnaa@musoni.eu>
Date:   2016-07-14T13:32:59Z

    commit for FINERACT-44 (Cannot delete an inactive charge associated with a product (loan/savings))

----


> Cannot delete an inactive charge associated with a product (loan/savings)
> -------------------------------------------------------------------------
>
>                 Key: FINERACT-44
>                 URL: https://issues.apache.org/jira/browse/FINERACT-44
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Emmanuel Nnaa
>            Assignee: Markus Geiss
>            Priority: Minor
>
> The SQL statement in the methods (isAnyLoansAssociateWithThisCharge and isAnySavingsAssociateWithThisCharge)
that check if a charge is attached to a product (loan or savings) does not include the "and
is_active = 1" criterion.
> *Solution*
> {code}
> final String sql = "select if((exists (select 1 from m_loan_charge lc where lc.charge_id
= ? and lc.is_active = 1)) = 1, 'true', 'false')";
> final String sql = "select if((exists (select 1 from m_savings_account_charge sc where
sc.charge_id = ? and sc.is_active = 1)) = 1, 'true', 'false')";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message