fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request #129: 504 loan write off reason added
Date Thu, 09 Jun 2016 08:44:37 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/129#discussion_r66402665
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
---
    @@ -1039,12 +1045,20 @@ public CommandProcessingResult writeOff(final Long loanId, final
JsonCommand com
     
             this.loanEventApiJsonValidator.validateTransactionWithNoAmount(command.json());
     
    +        Long writeoffReasonId = command.longValueOfParameterNamed("writeoffReasonId");
             final Map<String, Object> changes = new LinkedHashMap<>();
             changes.put("transactionDate", command.stringValueOfParameterNamed("transactionDate"));
             changes.put("locale", command.locale());
             changes.put("dateFormat", command.dateFormat());
    +        changes.put("writeoffReasonId", writeoffReasonId);
    --- End diff --
    
    If writeoffReasonId is not passed from client, why do we need to add writeoffReasonId
to changes map?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message