Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6ED6B2007D1 for ; Thu, 12 May 2016 12:48:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6D850160939; Thu, 12 May 2016 10:48:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6AF0160868 for ; Thu, 12 May 2016 12:48:32 +0200 (CEST) Received: (qmail 25343 invoked by uid 500); 12 May 2016 10:48:31 -0000 Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.incubator.apache.org Delivered-To: mailing list dev@fineract.incubator.apache.org Received: (qmail 25332 invoked by uid 99); 12 May 2016 10:48:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2016 10:48:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3F3F0C88AE for ; Thu, 12 May 2016 10:48:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.436 X-Spam-Level: X-Spam-Status: No, score=-5.436 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.416] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vxj9HuTX7b1P for ; Thu, 12 May 2016 10:48:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 579065F484 for ; Thu, 12 May 2016 10:48:28 +0000 (UTC) Received: (qmail 25306 invoked by uid 99); 12 May 2016 10:48:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2016 10:48:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 70F07DFC6C; Thu, 12 May 2016 10:48:27 +0000 (UTC) From: rajuan To: dev@fineract.incubator.apache.org Reply-To: dev@fineract.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t... Content-Type: text/plain Message-Id: <20160512104827.70F07DFC6C@git1-us-west.apache.org> Date: Thu, 12 May 2016 10:48:27 +0000 (UTC) archived-at: Thu, 12 May 2016 10:48:33 -0000 Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63000180 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @@ -18,9 +18,10 @@ */ --- End diff -- I have generally given the comments.... I will let other code experts to comment on sufficiency of the solution and also if there are any more problems with usecases --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---