fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <Ross.Gard...@microsoft.com>
Subject RE: [MENTORS] Re: [VOTE] [FINERACT] 0.1.2-incubating for release
Date Mon, 09 May 2016 15:27:19 GMT
Gradle is Apache licensed, so there should be no concerns assuming GradleWrapper is also Apache.



Sent from my Windows 10 phone



From: Myrle Krantz<mailto:mkrantz@mifos.org>
Sent: Monday, May 9, 2016 5:29 AM
To: dev@fineract.incubator.apache.org<mailto:dev@fineract.incubator.apache.org>
Subject: [MENTORS] Re: [VOTE] [FINERACT] 0.1.2-incubating for release





The hibernate issue, I was merely mentioning for completeness

gradlewrapper.jar, I don't want changed in this release, but for the next
release: MENTORS? Is there a reason we shouldn't include a
gradlewrapper.jar in our release zip?

w.r.t password: it'd be really nice if we could override that property for
the gradle scripts.  It should theoretically be possible. I'll look into it
for the next release. As a matter of habit, I don't like using default
passwords.

w.r.t. MySQL version: you're right.  My bad.

Greets,
Myrle




*Myrle Krantz*
Solutions Architect
RɅĐɅЯ, The Mifos Initiative
mkrantz@mifos.org | Skype: mkrantz.mifos.org | https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmifos.org&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=lsZNFUFsrMGvTW91ynk92vewQCREdobtKV3TPlMZk84%3d
<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2ffacebook.com%2fmifos&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=PzuicStNRDN83kmSbqOGoLl16DJbVAEP5UDW7uxMG%2fg%3d>
 <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.twitter.com%2fmifos&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=BBs6pNEfWBzPp5lPwJNAPwK7R%2bCpQN4vtnNzW6KgMQE%3d>


On Mon, May 9, 2016 at 2:15 PM, Nazeer Shaik <
nazeer.shaik@confluxtechnologies.com> wrote:

> Hi Myrle,
>
> Thank you for reviewing this release and please find my comments below.
>
> > I checked NOTICE and license files.
> >We still have that pesky hibernate problem.  This may well trip us up in
> >general incubation voting.
> As suggested by Justin we will initiate a separate mail thread with legal
> VP for the approval on 'gpl' dependency before sending this release for
> general incubating votes.
>
> >I did wonder why we do not include the gradlewrapper jar in the source
> >distribution.
> Since this is source only release, we shouldn't want to include any jar
> file in it (as suggested by mentor).
>
> >I tried the instructions for running integration tests:
> >I had to change my db password to mysql to get the gradle scripts to work.
> We have hard coded database password as 'mysql' in migration scripts and in
> integration tests only. Usually these properties are read from server
> config files and platform tenants databases and Fineract takes care DB
> migrations automatically once we restart server with new migration scripts.
>
> >FAILURE: Build failed with an exception.
> The prerequisite for Fineract is MySQL 5.5 which is already mentioned in
> README.md. You are facing the issue because you might have MySQL 5.7
> version. Migration scripts won't work on MySQL 5.7. Please check on MySQL
> 5.5
>
> Thanks,
> Nazeer
>
> On Mon, May 9, 2016 at 4:33 PM, Myrle Krantz <mkrantz@mifos.org> wrote:
>
> > +1
> >
> > As you'll notice from my description below, there are several weaknesses
> in
> > this release, but I want us to go through the experience of voting on a
> > release in the general incubator board, so that we can get a more
> complete
> > view of what further problems we might have and start working on them.
> > Nothing I saw was a blocker for an incubating release, but for a
> top-level
> > project release, I will raise my standards.
> >
> > Greets from the Voreifel, Germany,
> > Myrle
> >
> >
> > 1.) I checked NOTICE and license files.
> > We still have that pesky hibernate problem.  This may well trip us up in
> > general incubation voting.
> >
> > 2.) I also built from source:
> > I did wonder why we do not include the gradlewrapper jar in the source
> > distribution.
> > I followed the instructions in the gradle website (
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs.gradle.org%2fcurrent%2fuserguide%2fgradle_wrapper.html&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=5LGlfFRtiyI%2bpwX%2fIX4lAoXuPA7SnIsC0IZCnWHH7BQ%3d)
to
> download
> > the specified gradle wrapper, rather than following the instructions
> > literally.  My attempt to follow the instructions literally failed.
> >
> > 3.) I tried the instructions for running integration tests:
> > I had to change my db password to mysql to get the gradle scripts to
> work.
> > There's probably a better way, but I didn't bother to spend time
> searching.
> > Step 4.b. failed on my first attempt.  I dropped the db
> > mifostenant-default, and tried again and it still failed.  Here's the
> > error:
> >
> > "
> > FAILURE: Build failed with an exception.
> >
> > * Where:
> > Build file
> >
> >
> '/home/myrle/Downloads/apache-fineract-0.1.2-incubating-src/fineract-provider/build.gradle'
> > line: 264
> >
> > * What went wrong:
> > Execution failed for task ':flywayMigrate'.
> > > Error occurred while executing flywayMigrate
> >   Error executing statement at line 235: call migrate_withdrwal_fees()
> >   Expression #3 of SELECT list is not in GROUP BY clause and contains
> > nonaggregated column 'mifostenant-default.sa.withdrawal_fee_amount' which
> > is not functionally dependent on columns in GROUP BY clause; this is
> > incompatible with sql_mode=only_full_group_by
> >   Expression #3 of SELECT list is not in GROUP BY clause and contains
> > nonaggregated column 'mifostenant-default.sa.withdrawal_fee_amount' which
> > is not functionally dependent on columns in GROUP BY clause; this is
> > incompatible with sql_mode=only_full_group_by
> > "
> >
> > 4.) I checked the signature:
> > I checked that the signature is valid, and did fingerprint check with
> > Nazeer via Skype.  This is not an ideal fingerprint check, but I don't
> know
> > Nazeer well enough that any other method would give me any better
> > information.
> >
> >
> >
> > *Myrle Krantz*
> > Solutions Architect
> > RɅĐɅЯ, The Mifos Initiative
> > mkrantz@mifos.org | Skype: mkrantz.mifos.org | https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmifos.org&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=lsZNFUFsrMGvTW91ynk92vewQCREdobtKV3TPlMZk84%3d
> > <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2ffacebook.com%2fmifos&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=PzuicStNRDN83kmSbqOGoLl16DJbVAEP5UDW7uxMG%2fg%3d>
 <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.twitter.com%2fmifos&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=BBs6pNEfWBzPp5lPwJNAPwK7R%2bCpQN4vtnNzW6KgMQE%3d>
> >
> >
> > On Mon, May 9, 2016 at 5:59 AM, Roman Shaposhnik <roman@shaposhnik.org>
> > wrote:
> >
> > > Hi Nazeer,
> > >
> > > thanks for working on the release. VOTE threads on ASF releases
> > > typically follow a particular pattern of what information they
> > communicate
> > > to make the voting process easier. Here's a good example:
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail-archives.apache.org%2fmod_mbox%2fincubator-madlib-dev%2f201602.mbox%2f%253CCAKBQfzT6fn1Mzhs9gtEBC6m_pe%3dU1qzaRLF2rV5%3d7wPGV-SXag%40mail.gmail.com%253E&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=dsv87HWuMwsyZkvAD%2bsK4GpfUWAsCsLR61%2bZk52MG2I%3d
> > >
> > > Also, I would highly encourage you to start a wiki page documenting
> > > the process of releases to make next RM's job easier. Once again,
> > > here's a good (if only exhaustive!) example:
> > >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcwiki.apache.org%2fconfluence%2fdisplay%2fGEODE%2fRelease%2bproccess&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=72cjOpePqj2jlxhEW%2bxvbSs6w94Zq8LPuD%2bCrVVDUu8%3d
> > >
> > > Thanks,
> > > Roman.
> > >
> > > On Fri, May 6, 2016 at 5:03 AM, Nazeer Shaik
> > > <nazeer.shaik@confluxtechnologies.com> wrote:
> > > > Hi all,
> > > >
> > > > We have resolved windows line feeds issue and prepared
> 0.1.2-incubating
> > > > release for FINERACT. The files are hosted at
> > > >
> > > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fincubator%2ffineract%2f0.1.2-incubating%2f&data=01%7c01%7cRoss.Gardler%40microsoft.com%7cb26c0dc7d1824bfc34b108d378059a99%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=YYgR6in2FuFtc%2fnCPavTXWusxPMEsWi0mUkRjiYPhHU%3d
> > > >
> > > > The git repository is located at
> > > > https://github.com/apache/incubator-fineract/tree/0.1.2-incubating
> > > >
> > > > Again, this is source only release with no binaries, with
> instructions
> > on
> > > > how to build/test the application.
> > > >
> > > > I call for VOTING for this release and this voting closes by
> Wednesday
> > > > (11-May-2016) evening.
> > > >
> > > > Thanks,
> > > > Nazeer
> > >
> >
>
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message