fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: fineract collection sheet
Date Fri, 27 May 2016 10:26:13 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/125#discussion_r64886182
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/CentersApiResource.java
---
    @@ -155,6 +156,8 @@ public String retrieveAll(@Context final UriInfo uriInfo, @QueryParam("sqlSearch
             final ApiRequestJsonSerializationSettings settings = this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());
             if (meetingDateParam != null && officeId != null) {
                 Date meetingDate = meetingDateParam.getDate("meetingDate", dateFormat, locale);
    +			LocalDate date = new LocalDate(meetingDate);
    +			CenterReadPlatformServiceImpl.datePassed = date;
    --- End diff --
    
    Why are you assigning meeting date to a static variable in CenterReadPlatformServiceImpl


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message