fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jroweboy <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...
Date Thu, 12 May 2016 17:25:47 GMT
Github user jroweboy commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/110#discussion_r63061348
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
---
    @@ -96,10 +96,37 @@ public LocalDate generateNextRepaymentDate(final LocalDate lastRepaymentDate,
fi
                             loanApplicationTerms.getNumberOfdays());
                 }
             }
    -        
    +        if (currentCalendar == null && holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays())
{
    --- End diff --
    
    This sounds like a design decision that I will need to ask about. But I agree that something
needs to change. Imagine the case where a loan has been dispersed, and then a holiday is added
that affects a future repayment. This patch does not account for this case, and I'm guessing
that it should. Good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message